feat(Tenants): add network column #2478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1925-dbs-network
branch
from
484ec3c to
8f69647
Compare
artemmufazalov
changed the title
Raubzeug
approved these changes
Jun 30, 2025
|
bugbot run |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a network column to the Tenants table when the "Show network utilization" experiment is enabled.
- New imports and constants (formatBytes, EMPTY_DATA_PLACEHOLDER, SHOW_NETWORK_UTILIZATION) are added to support the feature.
- A new setting (showNetworkUtilization) is used to conditionally render the "Network" column with appropriate formatting.
- The columns array is updated to include the "Network" column with sorting and rendering logic.
Comments suppressed due to low confidence (1)
src/containers/Tenants/Tenants.tsx:243
- Verify that the isNumeric function correctly handles all the expected formats for NetworkWriteThroughput; consider adding a comment or a unit test if there are edge cases.
if (!isNumeric(NetworkWriteThroughput)) {
| header: 'Network', | ||
| width: 120, | ||
| align: DataTable.RIGHT, | ||
| defaultOrder: DataTable.DESCENDING, |
There was a problem hiding this comment.
[nitpick] Consider adding a brief comment here to clarify why NetworkWriteThroughput defaults to 0 to improve code readability.
Suggested change
| defaultOrder: DataTable.DESCENDING, | |
| defaultOrder: DataTable.DESCENDING, | |
| // Defaulting NetworkWriteThroughput to 0 to represent missing data or no network activity. |
Copilot uses AI. Check for mistakes.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
astandrik
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1925
Stand: https://nda.ya.ru/t/TPpOcAN57Fpbjh
You need to turn on experiment "Show network utilization"
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️3
⏭️ Skipped Tests (3)
Bundle Size: ✅
Current: 84.00 MB | Main: 84.00 MB
Diff: +1.94 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information